Skip to content

MT-22040: upgrade github-actions CI and composite runtimes#68

Open
leonid-shevtsov wants to merge 2 commits into
masterfrom
MT-22040-upgrade-github-actions-ci-and-runtimes
Open

MT-22040: upgrade github-actions CI and composite runtimes#68
leonid-shevtsov wants to merge 2 commits into
masterfrom
MT-22040-upgrade-github-actions-ci-and-runtimes

Conversation

@leonid-shevtsov
Copy link
Copy Markdown
Member

@leonid-shevtsov leonid-shevtsov commented May 11, 2026

Changes

  • Replace third-party workflow run cleanup with native concurrency and cancel-in-progress (same rules: no cancel on master or tags).
  • Bump official Actions to current majors (actions/checkout@v6, setup-node@v6 with node-version-file and Yarn cache, upload-artifact@v7, pinned action-slack@v3.19.0).
  • Install Yarn 1.22.22 globally in CI so the v1 lockfile stays consistent with runner defaults.
  • Move .node-version to Node 22; set composite actions to node24 runtime.
  • Refresh @actions/core, AWS SDK v3 clients, and yarn.lock; rebuild ncc bundles (including new chunk files under dist/).

How to test

  • No testing needed

Summary by CodeRabbit

  • Chores
    • Updated Node.js version to 22.22.2
    • Modernized GitHub Actions to latest versions
    • Optimized workflow concurrency to cancel in-progress runs efficiently
    • Upgraded core dependencies and AWS SDK packages
    • Configured build artifacts for improved pull request visibility

Review Change Stack

leonid-shevtsov and others added 2 commits May 11, 2026 14:03
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@leonid-shevtsov leonid-shevtsov marked this pull request as ready for review May 11, 2026 11:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

📝 Walkthrough

Walkthrough

This PR modernizes the repository's CI infrastructure and Node.js runtime environment. Node.js is upgraded from version 20 to 22 in the base configuration, all custom GitHub Actions are migrated from node20 to node24 runtime, and runtime dependencies are updated uniformly across the actions. The workflow is simplified with modern action versions and built-in concurrency handling.

Changes

Node.js Runtime and Dependency Modernization

Layer / File(s) Summary
CI Configuration & Node.js Setup
.gitattributes, .node-version, .github/workflows/main.yml
.gitattributes marks dist directories as linguist-generated. .node-version updated to Node.js 22.22.2. Workflow adds concurrency settings to cancel duplicate runs on the same ref (excluding tags and master). Node setup modernized to actions/checkout@v6 and actions/setup-node@v6 with .node-version file and cache enabled; Yarn classic v1.22.22 installed explicitly.
Workflow Action Versions
.github/workflows/main.yml
Artifact upload step updated to actions/upload-artifact@v7. Slack notification action pinned to 8398a7/action-slack@v3.19.0.
Action Runtime Migration
fetch-task-definition/action.yml, github-ref-to-env/action.yml, read-from-ssm-param-store/action.yml, register-ecs-task-definition/action.yml, run-ecs-task/action.yml
All five custom actions update runs.using from node20 to node24.
Action Dependencies
fetch-task-definition/package.json, github-ref-to-env/package.json, read-from-ssm-param-store/package.json, register-ecs-task-definition/package.json, run-ecs-task/package.json
@actions/core bumped from ^1.9.1 to ^1.11.1 across all actions. AWS SDK v3 clients (@aws-sdk/client-ssm, @aws-sdk/client-ecs, @aws-sdk/client-cloudwatch-logs) updated from ^3.624.0 to ^3.1045.0 in affected actions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hopping through versions with care and delight,
Node twenty-two, Node twenty-four—all shiny and bright!
Dependencies dance, concurrency flows,
This modernization smoothly goes!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: upgrading GitHub Actions CI workflows and composite action runtimes to newer versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description covers the main changes but omits the Motivation section and Images/GIFs section from the template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MT-22040-upgrade-github-actions-ci-and-runtimes

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/main.yml:
- Around line 14-17: Replace mutable GitHub Actions refs with their immutable
commit SHAs for the four usages mentioned: change the `uses:` entries for
actions/checkout@v6, actions/setup-node@v6, actions/upload-artifact@v7, and
8398a7/action-slack@v3.19.0 to the corresponding full commit SHAs (obtain the
exact SHA from each action’s GitHub repository/tags) so the workflow pins to a
specific commit; update the `uses:` values to those SHAs and confirm the
workflow still runs by testing the CI.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 56553fef-4436-4a3b-a552-3327153c17d9

📥 Commits

Reviewing files that changed from the base of the PR and between 427bae5 and a50bead.

⛔ Files ignored due to path filters (36)
  • fetch-task-definition/dist/index.js is excluded by !**/dist/**
  • github-ref-to-env/dist/index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/136.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/254.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/287.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/410.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/448.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/520.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/544.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/578.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/589.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/919.index.js is excluded by !**/dist/**
  • read-from-ssm-param-store/dist/index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/136.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/254.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/287.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/410.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/448.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/520.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/544.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/578.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/589.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/919.index.js is excluded by !**/dist/**
  • register-ecs-task-definition/dist/index.js is excluded by !**/dist/**
  • run-ecs-task/dist/136.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/254.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/287.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/410.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/448.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/520.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/544.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/578.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/589.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/919.index.js is excluded by !**/dist/**
  • run-ecs-task/dist/index.js is excluded by !**/dist/**
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (13)
  • .gitattributes
  • .github/workflows/main.yml
  • .node-version
  • fetch-task-definition/action.yml
  • fetch-task-definition/package.json
  • github-ref-to-env/action.yml
  • github-ref-to-env/package.json
  • read-from-ssm-param-store/action.yml
  • read-from-ssm-param-store/package.json
  • register-ecs-task-definition/action.yml
  • register-ecs-task-definition/package.json
  • run-ecs-task/action.yml
  • run-ecs-task/package.json

Comment thread .github/workflows/main.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants